Describe all callable arguments with types for Promise and Deferred#253
Merged
WyriHaximus merged 2 commits intoreactphp:3.xfrom Sep 11, 2023
Merged
Describe all callable arguments with types for Promise and Deferred#253WyriHaximus merged 2 commits intoreactphp:3.xfrom
Promise and Deferred#253WyriHaximus merged 2 commits intoreactphp:3.xfrom
Conversation
stylder
approved these changes
Sep 11, 2023
|
I suggest adding |
Member
Author
Go ahead, PRs welcome 👍 Tested this out locally and appears to report a number of low-priority types for internal functions and tests only, but happy to consider this if the changeset is reasonable 👍 |
|
I'll let you merge this PR first then, so that those types are already defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset describes all callable arguments with types for
PromiseandDeferred. In particular, this makes it easier to detect incorrect usage using static analysis, such as when omitting required arguments as discussed in #213 and #138.Builds on top of #247, #246 and others
Closes #252